add support for RockyLinux driver containers #2044
Open
+74
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tariq1890
force-pushed
the
rocky-support
branch
3 times, most recently
from
b7f8fee to
28df39e
Compare
tariq1890
requested review from
ArangoGutierrez,
cdesiniotis,
elezar and
shivamerla
as code owners
cdesiniotis
reviewed
Jan 28, 2026
internal/state/nodepool.go
Outdated
| func (n nodePool) getOS() string { | ||
| if n.osRelease == "rocky" { | ||
| // If the OS is RockyLinux, we will omit the RockyLinux minor version when constructing the os image tag | ||
| n.osVersion = strings.Split(n.osRelease, ".")[0] |
Contributor
There was a problem hiding this comment.
Should this be
Suggested change
| n.osVersion = strings.Split(n.osRelease, ".")[0] | |
| n.osVersion = strings.Split(n.osVersion, ".")[0] |
?
Contributor
Author
There was a problem hiding this comment.
Yes, great catch! Thanks
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
tariq1890
force-pushed
the
rocky-support
branch
from
28df39e to
2ce61f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.